commit d8f923c3ab96dbbb4e3c22d1afc1dc1d3b195cd8
author Pan Bian <bianpan2016@163.com> Thu Jan 21 07:37:45 2021 -0800
committer Jakub Kicinski <kuba@kernel.org> Sat Jan 23 13:34:31 2021 -0800
tree ab4b25299577a13860e505311b749a68bc197e63
parent fc024c5c07aa2463d36e8c85943343741ba356b7

NFC: fix possible resource leak

Put the device to avoid resource leak on path that the polling flag is
invalid.

Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Link: https://lore.kernel.org/r/20210121153745.122184-1-bianpan2016@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

net/nfc/netlink.c

diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 573b38a..e161ef2 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -852,6 +852,7 @@ static int nfc_genl_stop_poll(struct sk_buff *skb, struct genl_info *info)
 
 	if (!dev->polling) {
 		device_unlock(&dev->dev);
+		nfc_put_device(dev);
 		return -EINVAL;
 	}