commit dd6c5cd8fedddc9605209098e2fa4e82c7af22aa
author Al Viro <viro@zeniv.linux.org.uk> Wed Jun 05 14:07:08 2013 -0400
committer Al Viro <viro@zeniv.linux.org.uk> Sat Jun 15 05:42:42 2013 +0400
tree 652ebd37f734f7feea8aab5ba7ee10112a4c1df9
parent 05252901199d886a68830befb135d1723730ca86

snd_pcm_link(): fix a leak...

in case when snd_pcm_stream_linked(substream) is true, we end up leaking
group.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

sound/core/pcm_native.c

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index ccfa383..f928181 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -1649,6 +1649,7 @@
 	}
 	if (!snd_pcm_stream_linked(substream)) {
 		substream->group = group;
+		group = NULL;
 		spin_lock_init(&substream->group->lock);
 		INIT_LIST_HEAD(&substream->group->substreams);
 		list_add_tail(&substream->link_list, &substream->group->substreams);
@@ -1663,8 +1664,7 @@
  _nolock:
 	snd_card_unref(substream1->pcm->card);
 	fput_light(file, fput_needed);
-	if (res < 0)
-		kfree(group);
+	kfree(group);
 	return res;
 }