commit de6f83f85be94e0b7d0d324c29ccc9d78a6bb4e7
author Christophe JAILLET <christophe.jaillet@wanadoo.fr> Wed Mar 14 20:56:37 2018 +0100
committer Bjorn Andersson <bjorn.andersson@linaro.org> Sun Mar 18 15:43:46 2018 -0700
tree 9cf902358363b428c8e91ab40f9444dfefd4beca
parent 842891be96bd2b90f0e7d44192d45f61bab17926

remoteproc: imx_rproc: Fix an error handling path in 'imx_rproc_probe()'

If 'of_device_get_match_data()' fails, we must undo the previous
'rproc_alloc()' call.

Fixes: a0ff4aa6f010 ("remoteproc: imx_rproc: add a NXP/Freescale imx_rproc driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

drivers/remoteproc/imx_rproc.c

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 633268e..05bcbce 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -339,8 +339,10 @@ static int imx_rproc_probe(struct platform_device *pdev)
 	}
 
 	dcfg = of_device_get_match_data(dev);
-	if (!dcfg)
-		return -EINVAL;
+	if (!dcfg) {
+		ret = -EINVAL;
+		goto err_put_rproc;
+	}
 
 	priv = rproc->priv;
 	priv->rproc = rproc;