commit e7bf352fcd85c33b0805da891fc97fea8b5e996e
author roel kluin <roel.kluin@gmail.com> Mon Jan 03 11:59:48 2011 -0800
committer Greg Kroah-Hartman <gregkh@suse.de> Thu Jan 20 12:06:07 2011 -0800
tree c9992869fdd493a198fee0df104a657b0dfed714
parent e71a7fd259943a2c2e11484880c80248ad139fe5

Staging: speakup: &&/|| confusion in silent_store()

Fix test: the branch is always taken.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/staging/speakup/kobjects.c

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 408bb9b..07a7f54 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -332,7 +332,7 @@
 	unsigned long flags;
 
 	len = strlen(buf);
-	if (len > 0 || len < 3) {
+	if (len > 0 && len < 3) {
 		ch = buf[0];
 		if (ch == '\n')
 			ch = '0';