tree 6980b7c332c264d8d29cb7e67e01a1bed0149458
parent 7d30c81b80ea9b0812d27030a46a5bf4c4e328f5
author Wenwen Wang <wenwen@cs.uga.edu> 1562872922 -0500
committer Jens Axboe <axboe@kernel.dk> 1562896881 -0600

block/bio-integrity: fix a memory leak bug

In bio_integrity_prep(), a kernel buffer is allocated through kmalloc() to
hold integrity metadata. Later on, the buffer will be attached to the bio
structure through bio_integrity_add_page(), which returns the number of
bytes of integrity metadata attached. Due to unexpected situations,
bio_integrity_add_page() may return 0. As a result, bio_integrity_prep()
needs to be terminated with 'false' returned to indicate this error.
However, the allocated kernel buffer is not freed on this execution path,
leading to a memory leak.

To fix this issue, free the allocated buffer before returning from
bio_integrity_prep().

Reviewed-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Jens Axboe <axboe@kernel.dk>