tree fbdfed7207868ed976415046c64eaf4cc6d40bb8
parent c836d9d17a7d102ded1ba4dbd4ee0bc42ba26211
author Nathan Chancellor <nathan@kernel.org> 1652899529 -0700
committer Palmer Dabbelt <palmer@rivosinc.com> 1655471806 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQJHBAABCAAxFiEEAM520YNJYN/OiG3470yhUCzLq0EFAmKsfr4THHBhbG1lckBk
 YWJiZWx0LmNvbQAKCRDvTKFQLMurQehrEACLdqmpeiHY/XK0R5lAz0IPIJTQkWlX
 gU9heB4C6wn2qn/kcW1FH6WAihUAqD7tDG4GQjH5+yfTUlpozWkQLQqXmMnmGw7Y
 91L8QcxdluSIe0gGaEVaSxZsDbyerc1qGzKLeUbC4nYzfKHfL3BQ/4fHYsIW7Y+0
 U4io1WZ7jLQzARQKo0AApabm7h1Z7Bh21+moMM7u6Z9XymtnowpMpBD+QTaQPLPx
 O9zndCfT4FqF8TIHF9KnE4+wZ4R0S8yKLIcfn67TiUqP9l6X8NkQol2z2LefclGD
 p5pQIbrlWEUcxXUwuM5r16h2upXyCVGx93P51KDhJFXSIKcIrTQIqkVGy3Y9fcVq
 FieIv1C4v8qof69ukh//mcxJl0dt9Z/6KNNv6DqjWi+BD/WkHMSFPUuiaUpvg9WB
 wt1UbfPW9ukqulkalvt2iEYKiUaBfx2so5cHW7gLLBWQBqaMA+3myHr1i50RRG66
 Vf30jby3oLB8PvPTA49VLYuUpSr16+UQt3Q89x047IiQ28O9fkxpkQV9iXBLNs3m
 46Huf8SsIX1eWXGqqu+V38MSMm8BRECPV0rd/T67FPhOMiVMq8bvSf9moA1UtkIJ
 6iruQazq9cOVW1V1lo2FSEy0Ey1/FKRCGv9sE8YXmss40HUbraIdlm+zYknncSbB
 io1EC0nvKsQgyQ==
 =xPoc
 -----END PGP SIGNATURE-----

riscv: Fix ALT_THEAD_PMA's asm parameters

After commit a35707c3d850 ("riscv: add memory-type errata for T-Head"),
builds with LLVM's integrated assembler fail like:

  In file included from arch/riscv/kernel/asm-offsets.c:10:
  In file included from ./include/linux/mm.h:29:
  In file included from ./include/linux/pgtable.h:6:
  In file included from ./arch/riscv/include/asm/pgtable.h:114:
  ./arch/riscv/include/asm/pgtable-64.h:210:2: error: invalid input constraint '0' in asm
          ALT_THEAD_PMA(prot_val);
          ^
  ./arch/riscv/include/asm/errata_list.h:88:4: note: expanded from macro 'ALT_THEAD_PMA'
          : "0"(_val),                                                    \
            ^

This was reported upstream to LLVM where Jessica pointed out a couple of
issues with the existing implementation of ALT_THEAD_PMA:

* t3 is modified but not listed in the clobbers list.

* "+r"(_val) marks _val as both an input and output of the asm but then
  "0"(_val) marks _val as an input matching constraint, which does not
  make much sense in this situation, as %1 is not actually used in the
  asm and matching constraints are designed to be used for different
  inputs that need to use the same register.

Drop the matching contraint and shift all the operands by one, as %1 is
unused, and mark t3 as clobbered. This resolves the build error and goes
not cause any problems with GNU as.

Fixes: a35707c3d850 ("riscv: add memory-type errata for T-Head")
Link: https://github.com/ClangBuiltLinux/linux/issues/1641
Link: https://github.com/llvm/llvm-project/issues/55514
Link: https://gcc.gnu.org/onlinedocs/gcc/Simple-Constraints.html
Suggested-by: Jessica Clarke <jrtc27@jrtc27.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20220518184529.454008-1-nathan@kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>