orangefs: don't d_drop in d_revalidate since the caller will
Signed-off-by: Martin Brandenburg <martin@omnibond.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
diff --git a/fs/orangefs/dcache.c b/fs/orangefs/dcache.c
index a6911db..3c1703f 100644
--- a/fs/orangefs/dcache.c
+++ b/fs/orangefs/dcache.c
@@ -82,7 +82,6 @@
out_drop:
gossip_debug(GOSSIP_DCACHE_DEBUG, "%s:%s:%d revalidate failed\n",
__FILE__, __func__, __LINE__);
- d_drop(dentry);
goto out_release_op;
}
@@ -109,10 +108,8 @@
* If this passes, the positive dentry still exists or the negative
* dentry still does not exist.
*/
- if (!orangefs_revalidate_lookup(dentry)) {
- d_drop(dentry);
+ if (!orangefs_revalidate_lookup(dentry))
return 0;
- }
/* We do not need to continue with negative dentries. */
if (!dentry->d_inode)
@@ -125,13 +122,10 @@
if (ret < 0) {
gossip_debug(GOSSIP_DCACHE_DEBUG, "%s:%s:%d getattr failure.\n",
__FILE__, __func__, __LINE__);
- d_drop(dentry);
return 0;
}
- if (ret == 0) {
- d_drop(dentry);
+ if (ret == 0)
return 0;
- }
out:
gossip_debug(GOSSIP_DCACHE_DEBUG,
