| From 1659226a96b1daecfd08c057d0d5c39309d207ee Mon Sep 17 00:00:00 2001 |
| From: Giulio Benetti <giulio.benetti@benettiengineering.com> |
| Date: Mon, 22 Mar 2021 13:30:07 +0100 |
| Subject: [PATCH] bfd/elf32-or1k: fix ld assert |
| |
| Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=27624 |
| |
| Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> |
| --- |
| bfd/elf32-or1k.c | 9 ++++----- |
| 1 file changed, 4 insertions(+), 5 deletions(-) |
| |
| diff --git a/bfd/elf32-or1k.c b/bfd/elf32-or1k.c |
| index 65938e5137..41908f8938 100644 |
| --- a/bfd/elf32-or1k.c |
| +++ b/bfd/elf32-or1k.c |
| @@ -2566,11 +2566,10 @@ or1k_elf_adjust_dynamic_symbol (struct bfd_link_info *info, |
| if (h->type == STT_FUNC |
| || h->needs_plt) |
| { |
| - if (! bfd_link_pic (info) |
| - && !h->def_dynamic |
| - && !h->ref_dynamic |
| - && h->root.type != bfd_link_hash_undefweak |
| - && h->root.type != bfd_link_hash_undefined) |
| + if (h->plt.refcount <= 0 |
| + || (SYMBOL_CALLS_LOCAL (info, h) |
| + || (ELF_ST_VISIBILITY (h->other) != STV_DEFAULT |
| + && h->root.type == bfd_link_hash_undefweak))) |
| { |
| /* This case can occur if we saw a PLT reloc in an input |
| file, but the symbol was never referred to by a dynamic |
| -- |
| 2.25.1 |
| |