| commit | 1eb2cded45b35816085c1f962933c187d970f9dc | [log] [tgz] |
|---|---|---|
| author | Eric Dumazet <edumazet@google.com> | Mon May 06 10:28:12 2024 +0000 |
| committer | Jakub Kicinski <kuba@kernel.org> | Tue May 07 16:19:14 2024 -0700 |
| tree | 27a26692748d3c69fcd896a10db9bc89c1eb54b5 | |
| parent | feb8c2b76eb3fae59a1f62451508c98c36db5e3a [diff] |
net: annotate writes on dev->mtu from ndo_change_mtu()
Simon reported that ndo_change_mtu() methods were never
updated to use WRITE_ONCE(dev->mtu, new_mtu) as hinted
in commit 501a90c94510 ("inet: protect against too small
mtu values.")
We read dev->mtu without holding RTNL in many places,
with READ_ONCE() annotations.
It is time to take care of ndo_change_mtu() methods
to use corresponding WRITE_ONCE()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Simon Horman <horms@kernel.org>
Closes: https://lore.kernel.org/netdev/20240505144608.GB67882@kernel.org/
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Shannon Nelson <shannon.nelson@amd.com>
Link: https://lore.kernel.org/r/20240506102812.3025432-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>