commit 69294246b7a441a112d1a550ffc8e4e1e45142a4
author Kent Overstreet <kent.overstreet@gmail.com> Fri Oct 01 10:08:13 2021 -0400
committer Kent Overstreet <kent.overstreet@linux.dev> Sun Oct 22 17:09:13 2023 -0400
tree ec365d79743ff19a3cdc32370c89115d8b7da847
parent e59a4d787507592ea19dbf48bc71b3120ff5df4d

bcachefs: Fix allocator shutdown error message

We return 1 to indicate kthread_should_stop() returned true - we
shouldn't be printing an error.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>

fs/bcachefs/alloc_background.c

diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c
index 54fbfb2..fc1b4b35 100644
--- a/fs/bcachefs/alloc_background.c
+++ b/fs/bcachefs/alloc_background.c
@@ -857,10 +857,10 @@ static int bch2_invalidate_buckets(struct bch_fs *c, struct bch_dev *ca)
 	/* If we used NOWAIT, don't return the error: */
 	if (!fifo_empty(&ca->free_inc))
 		ret = 0;
-	if (ret) {
+	if (ret < 0)
 		bch_err(ca, "error invalidating buckets: %i", ret);
+	if (ret)
 		return ret;
-	}
 
 	if (journal_seq)
 		ret = bch2_journal_flush_seq(&c->journal, journal_seq);