commit baabaa505563362b71f2637aedd7b807d270656c
author Miklos Szeredi <mszeredi@redhat.com> Tue Jan 24 16:41:18 2023 +0100
committer Miklos Szeredi <mszeredi@redhat.com> Fri Jan 27 16:16:12 2023 +0100
tree 605153280b2efe756d9137f3aed7d6da767955a8
parent 2241ab53cbb5cdb08a6b2d4688feb13971058f65

ovl: fix tmpfile leak

Missed an error cleanup.

Reported-by: syzbot+fd749a7ea127a84e0ffd@syzkaller.appspotmail.com
Fixes: 2b1a77461f16 ("ovl: use vfs_tmpfile_open() helper")
Cc: <stable@vger.kernel.org> # v6.1
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

fs/overlayfs/copy_up.c

diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 6e4e65e..140f274 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -792,7 +792,7 @@
 	if (!c->metacopy && c->stat.size) {
 		err = ovl_copy_up_file(ofs, c->dentry, tmpfile, c->stat.size);
 		if (err)
-			return err;
+			goto out_fput;
 	}
 
 	err = ovl_copy_up_metadata(c, temp);