drivers/clk/meson/meson8b-clkc.c - linux - Git at Google

 /*
  * Copyright (c) 2015 Endless Mobile, Inc.
  * Author: Carlo Caione <carlo@endlessm.com>
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms and conditions of the GNU General Public License,
  * version 2, as published by the Free Software Foundation.
  *
  * This program is distributed in the hope it will be useful, but WITHOUT
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
  *
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see <http://www.gnu.org/licenses/>.
  */

 #include <linux/clk-provider.h>
 #include <linux/kernel.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/slab.h>
 #include <dt-bindings/clock/meson8b-clkc.h>

 #include "clkc.h"

 /*
  * Clock controller register offsets
  *
  * Register offsets from the HardKernel[0] data sheet are listed in comment
  * blocks below. Those offsets must be multiplied by 4 before adding them to
  * the base address to get the right value
  *
  * [0] http://dn.odroid.com/S805/Datasheet/S805_Datasheet%20V0.8%2020150126.pdf
  */
 #define MESON8B_REG_SYS_CPU_CNTL1	0x015c /* 0x57 offset in data sheet */
 #define MESON8B_REG_HHI_MPEG		0x0174 /* 0x5d offset in data sheet */
 #define MESON8B_REG_MALI		0x01b0 /* 0x6c offset in data sheet */
 #define MESON8B_REG_PLL_FIXED		0x0280
 #define MESON8B_REG_PLL_SYS		0x0300
 #define MESON8B_REG_PLL_VID		0x0320

 static const struct pll_rate_table sys_pll_rate_table[] = {
 	PLL_RATE(312000000, 52, 1, 2),
 	PLL_RATE(336000000, 56, 1, 2),
 	PLL_RATE(360000000, 60, 1, 2),
 	PLL_RATE(384000000, 64, 1, 2),
 	PLL_RATE(408000000, 68, 1, 2),
 	PLL_RATE(432000000, 72, 1, 2),
 	PLL_RATE(456000000, 76, 1, 2),
 	PLL_RATE(480000000, 80, 1, 2),
 	PLL_RATE(504000000, 84, 1, 2),
 	PLL_RATE(528000000, 88, 1, 2),
 	PLL_RATE(552000000, 92, 1, 2),
 	PLL_RATE(576000000, 96, 1, 2),
 	PLL_RATE(600000000, 50, 1, 1),
 	PLL_RATE(624000000, 52, 1, 1),
 	PLL_RATE(648000000, 54, 1, 1),
 	PLL_RATE(672000000, 56, 1, 1),
 	PLL_RATE(696000000, 58, 1, 1),
 	PLL_RATE(720000000, 60, 1, 1),
 	PLL_RATE(744000000, 62, 1, 1),
 	PLL_RATE(768000000, 64, 1, 1),
 	PLL_RATE(792000000, 66, 1, 1),
 	PLL_RATE(816000000, 68, 1, 1),
 	PLL_RATE(840000000, 70, 1, 1),
 	PLL_RATE(864000000, 72, 1, 1),
 	PLL_RATE(888000000, 74, 1, 1),
 	PLL_RATE(912000000, 76, 1, 1),
 	PLL_RATE(936000000, 78, 1, 1),
 	PLL_RATE(960000000, 80, 1, 1),
 	PLL_RATE(984000000, 82, 1, 1),
 	PLL_RATE(1008000000, 84, 1, 1),
 	PLL_RATE(1032000000, 86, 1, 1),
 	PLL_RATE(1056000000, 88, 1, 1),
 	PLL_RATE(1080000000, 90, 1, 1),
 	PLL_RATE(1104000000, 92, 1, 1),
 	PLL_RATE(1128000000, 94, 1, 1),
 	PLL_RATE(1152000000, 96, 1, 1),
 	PLL_RATE(1176000000, 98, 1, 1),
 	PLL_RATE(1200000000, 50, 1, 0),
 	PLL_RATE(1224000000, 51, 1, 0),
 	PLL_RATE(1248000000, 52, 1, 0),
 	PLL_RATE(1272000000, 53, 1, 0),
 	PLL_RATE(1296000000, 54, 1, 0),
 	PLL_RATE(1320000000, 55, 1, 0),
 	PLL_RATE(1344000000, 56, 1, 0),
 	PLL_RATE(1368000000, 57, 1, 0),
 	PLL_RATE(1392000000, 58, 1, 0),
 	PLL_RATE(1416000000, 59, 1, 0),
 	PLL_RATE(1440000000, 60, 1, 0),
 	PLL_RATE(1464000000, 61, 1, 0),
 	PLL_RATE(1488000000, 62, 1, 0),
 	PLL_RATE(1512000000, 63, 1, 0),
 	PLL_RATE(1536000000, 64, 1, 0),
 	{ /* sentinel */ },
 };

 static const struct clk_div_table cpu_div_table[] = {
 	{ .val = 1, .div = 1 },
 	{ .val = 2, .div = 2 },
 	{ .val = 3, .div = 3 },
 	{ .val = 2, .div = 4 },
 	{ .val = 3, .div = 6 },
 	{ .val = 4, .div = 8 },
 	{ .val = 5, .div = 10 },
 	{ .val = 6, .div = 12 },
 	{ .val = 7, .div = 14 },
 	{ .val = 8, .div = 16 },
 	{ /* sentinel */ },
 };

 PNAME(p_fclk_div)	= { "fixed_pll" };
 PNAME(p_cpu_clk)	= { "sys_pll" };
 PNAME(p_clk81)		= { "fclk_div3", "fclk_div4", "fclk_div5" };
 PNAME(p_mali)		= { "fclk_div3", "fclk_div4", "fclk_div5",
 			    "fclk_div7", "zero" };

 static u32 mux_table_clk81[]	= { 6, 5, 7 };
 static u32 mux_table_mali[]	= { 6, 5, 7, 4, 0 };

 static const struct composite_conf clk81_conf __initconst = {
 	.mux_table		= mux_table_clk81,
 	.mux_flags		= CLK_MUX_READ_ONLY,
 	.mux_parm		= PARM(0x00, 12, 3),
 	.div_parm		= PARM(0x00, 0, 7),
 	.gate_parm		= PARM(0x00, 7, 1),
 };

 static const struct composite_conf mali_conf __initconst = {
 	.mux_table		= mux_table_mali,
 	.mux_parm		= PARM(0x00, 9, 3),
 	.div_parm		= PARM(0x00, 0, 7),
 	.gate_parm		= PARM(0x00, 8, 1),
 };

 static struct clk_fixed_rate meson8b_xtal = {
 	.fixed_rate = 24000000,
 	.hw.init = &(struct clk_init_data){
 		.name = "xtal",
 		.num_parents = 0,
 		.ops = &clk_fixed_rate_ops,
 	},
 };

 static struct clk_fixed_rate meson8b_zero = {
 	.fixed_rate = 0,
 	.hw.init = &(struct clk_init_data){
 		.name = "zero",
 		.num_parents = 0,
 		.ops = &clk_fixed_rate_ops,
 	},
 };

 static struct meson_clk_pll meson8b_fixed_pll = {
 	.m = {
 		.reg_off = MESON8B_REG_PLL_FIXED,
 		.shift   = 0,
 		.width   = 9,
 	},
 	.n = {
 		.reg_off = MESON8B_REG_PLL_FIXED,
 		.shift   = 9,
 		.width   = 5,
 	},
 	.od = {
 		.reg_off = MESON8B_REG_PLL_FIXED,
 		.shift   = 16,
 		.width   = 2,
 	},
 	.lock = &clk_lock,
 	.hw.init = &(struct clk_init_data){
 		.name = "fixed_pll",
 		.ops = &meson_clk_pll_ro_ops,
 		.parent_names = (const char *[]){ "xtal" },
 		.num_parents = 1,
 		.flags = CLK_GET_RATE_NOCACHE,
 	},
 };

 static struct meson_clk_pll meson8b_vid_pll = {
 	.m = {
 		.reg_off = MESON8B_REG_PLL_VID,
 		.shift   = 0,
 		.width   = 9,
 	},
 	.n = {
 		.reg_off = MESON8B_REG_PLL_VID,
 		.shift   = 9,
 		.width   = 5,
 	},
 	.od = {
 		.reg_off = MESON8B_REG_PLL_VID,
 		.shift   = 16,
 		.width   = 2,
 	},
 	.lock = &clk_lock,
 	.hw.init = &(struct clk_init_data){
 		.name = "vid_pll",
 		.ops = &meson_clk_pll_ro_ops,
 		.parent_names = (const char *[]){ "xtal" },
 		.num_parents = 1,
 		.flags = CLK_GET_RATE_NOCACHE,
 	},
 };

 static struct meson_clk_pll meson8b_sys_pll = {
 	.m = {
 		.reg_off = MESON8B_REG_PLL_SYS,
 		.shift   = 0,
 		.width   = 9,
 	},
 	.n = {
 		.reg_off = MESON8B_REG_PLL_SYS,
 		.shift   = 9,
 		.width   = 5,
 	},
 	.od = {
 		.reg_off = MESON8B_REG_PLL_SYS,
 		.shift   = 16,
 		.width   = 2,
 	},
 	.rate_table = sys_pll_rate_table,
 	.rate_count = ARRAY_SIZE(sys_pll_rate_table),
 	.lock = &clk_lock,
 	.hw.init = &(struct clk_init_data){
 		.name = "sys_pll",
 		.ops = &meson_clk_pll_ops,
 		.parent_names = (const char *[]){ "xtal" },
 		.num_parents = 1,
 		.flags = CLK_GET_RATE_NOCACHE,
 	},
 };

 static const struct clk_conf meson8b_clk_confs[] __initconst = {
 	FIXED_FACTOR_DIV(CLKID_FCLK_DIV2, "fclk_div2", p_fclk_div, 0, 2),
 	FIXED_FACTOR_DIV(CLKID_FCLK_DIV3, "fclk_div3", p_fclk_div, 0, 3),
 	FIXED_FACTOR_DIV(CLKID_FCLK_DIV4, "fclk_div4", p_fclk_div, 0, 4),
 	FIXED_FACTOR_DIV(CLKID_FCLK_DIV5, "fclk_div5", p_fclk_div, 0, 5),
 	FIXED_FACTOR_DIV(CLKID_FCLK_DIV7, "fclk_div7", p_fclk_div, 0, 7),
 	CPU(MESON8B_REG_SYS_CPU_CNTL1, CLKID_CPUCLK, "a5_clk", p_cpu_clk,
 	    cpu_div_table),
 	COMPOSITE(MESON8B_REG_HHI_MPEG, CLKID_CLK81, "clk81", p_clk81,
 		  CLK_SET_RATE_NO_REPARENT | CLK_IGNORE_UNUSED, &clk81_conf),
 	COMPOSITE(MESON8B_REG_MALI, CLKID_MALI, "mali", p_mali,
 		  CLK_IGNORE_UNUSED, &mali_conf),
 };

 /*
  * FIXME we cannot register two providers w/o breaking things. Luckily only
  * clk81 is actually used by any drivers. Convert clk81 to use
  * clk_hw_onecell_data last and flip the switch to call of_clk_add_hw_provider
  * instead of of_clk_add_provider in the clk81 conversion patch to keep from
  * breaking bisect. Then delete this comment ;-)
  */
 static struct clk_hw_onecell_data meson8b_hw_onecell_data = {
 	.hws = {
 		[CLKID_XTAL] = &meson8b_xtal.hw,
 		[CLKID_ZERO] = &meson8b_zero.hw,
 		[CLKID_PLL_FIXED] = &meson8b_fixed_pll.hw,
 		[CLKID_PLL_VID] = &meson8b_vid_pll.hw,
 		[CLKID_PLL_SYS] = &meson8b_sys_pll.hw,
 	},
 	.num = CLK_NR_CLKS,
 };

 static struct meson_clk_pll *const meson8b_clk_plls[] = {
 	&meson8b_fixed_pll,
 	&meson8b_vid_pll,
 	&meson8b_sys_pll,
 };

 static void __init meson8b_clkc_init(struct device_node *np)
 {
 	void __iomem *clk_base;
 	int ret, clkid, i;

 	if (!meson_clk_init(np, CLK_NR_CLKS))
 		return;

 	/*  Generic clocks and PLLs */
 	clk_base = of_iomap(np, 1);
 	if (!clk_base) {
 		pr_err("%s: Unable to map clk base\n", __func__);
 		return;
 	}

 	/* Populate base address for PLLs */
 	for (i = 0; i < ARRAY_SIZE(meson8b_clk_plls); i++)
 		meson8b_clk_plls[i]->base = clk_base;

 	/*
 	 * register all clks
 	 * CLKID_UNUSED = 0, so skip it and start with CLKID_XTAL = 1
 	 */
 	for (clkid = CLKID_XTAL; clkid < CLK_NR_CLKS; clkid++) {
 		/* array might be sparse */
 		if (!meson8b_hw_onecell_data.hws[clkid])
 			continue;

 		/* FIXME convert to devm_clk_register */
 		ret = clk_hw_register(NULL, meson8b_hw_onecell_data.hws[clkid]);
 		if (ret)
 			goto unregister;
 	}

 	meson_clk_register_clks(meson8b_clk_confs,
 				ARRAY_SIZE(meson8b_clk_confs),
 				clk_base);
 	return;

 /* FIXME remove after converting to platform_driver/devm_clk_register */
 unregister:
 	for (clkid = CLK_NR_CLKS - 1; clkid >= 0; clkid--)
 		clk_hw_unregister(meson8b_hw_onecell_data.hws[clkid]);
 }
 CLK_OF_DECLARE(meson8b_clock, "amlogic,meson8b-clkc", meson8b_clkc_init);
	/*
	* Copyright (c) 2015 Endless Mobile, Inc.
	* Author: Carlo Caione <carlo@endlessm.com>
	*
	* This program is free software; you can redistribute it and/or modify it
	* under the terms and conditions of the GNU General Public License,
	* version 2, as published by the Free Software Foundation.
	*
	* This program is distributed in the hope it will be useful, but WITHOUT
	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
	* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
	* more details.
	*
	* You should have received a copy of the GNU General Public License along with
	* this program. If not, see <http://www.gnu.org/licenses/>.
	*/

	#include <linux/clk-provider.h>
	#include <linux/kernel.h>
	#include <linux/of.h>
	#include <linux/of_address.h>
	#include <linux/slab.h>
	#include <dt-bindings/clock/meson8b-clkc.h>

	#include "clkc.h"

	/*
	* Clock controller register offsets
	*
	* Register offsets from the HardKernel[0] data sheet are listed in comment
	* blocks below. Those offsets must be multiplied by 4 before adding them to
	* the base address to get the right value
	*
	* [0] http://dn.odroid.com/S805/Datasheet/S805_Datasheet%20V0.8%2020150126.pdf
	*/
	#define MESON8B_REG_SYS_CPU_CNTL1 0x015c /* 0x57 offset in data sheet */
	#define MESON8B_REG_HHI_MPEG 0x0174 /* 0x5d offset in data sheet */
	#define MESON8B_REG_MALI 0x01b0 /* 0x6c offset in data sheet */
	#define MESON8B_REG_PLL_FIXED 0x0280
	#define MESON8B_REG_PLL_SYS 0x0300
	#define MESON8B_REG_PLL_VID 0x0320

	static const struct pll_rate_table sys_pll_rate_table[] = {
	PLL_RATE(312000000, 52, 1, 2),
	PLL_RATE(336000000, 56, 1, 2),
	PLL_RATE(360000000, 60, 1, 2),
	PLL_RATE(384000000, 64, 1, 2),
	PLL_RATE(408000000, 68, 1, 2),
	PLL_RATE(432000000, 72, 1, 2),
	PLL_RATE(456000000, 76, 1, 2),
	PLL_RATE(480000000, 80, 1, 2),
	PLL_RATE(504000000, 84, 1, 2),
	PLL_RATE(528000000, 88, 1, 2),
	PLL_RATE(552000000, 92, 1, 2),
	PLL_RATE(576000000, 96, 1, 2),
	PLL_RATE(600000000, 50, 1, 1),
	PLL_RATE(624000000, 52, 1, 1),
	PLL_RATE(648000000, 54, 1, 1),
	PLL_RATE(672000000, 56, 1, 1),
	PLL_RATE(696000000, 58, 1, 1),
	PLL_RATE(720000000, 60, 1, 1),
	PLL_RATE(744000000, 62, 1, 1),
	PLL_RATE(768000000, 64, 1, 1),
	PLL_RATE(792000000, 66, 1, 1),
	PLL_RATE(816000000, 68, 1, 1),
	PLL_RATE(840000000, 70, 1, 1),
	PLL_RATE(864000000, 72, 1, 1),
	PLL_RATE(888000000, 74, 1, 1),
	PLL_RATE(912000000, 76, 1, 1),
	PLL_RATE(936000000, 78, 1, 1),
	PLL_RATE(960000000, 80, 1, 1),
	PLL_RATE(984000000, 82, 1, 1),
	PLL_RATE(1008000000, 84, 1, 1),
	PLL_RATE(1032000000, 86, 1, 1),
	PLL_RATE(1056000000, 88, 1, 1),
	PLL_RATE(1080000000, 90, 1, 1),
	PLL_RATE(1104000000, 92, 1, 1),
	PLL_RATE(1128000000, 94, 1, 1),
	PLL_RATE(1152000000, 96, 1, 1),
	PLL_RATE(1176000000, 98, 1, 1),
	PLL_RATE(1200000000, 50, 1, 0),
	PLL_RATE(1224000000, 51, 1, 0),
	PLL_RATE(1248000000, 52, 1, 0),
	PLL_RATE(1272000000, 53, 1, 0),
	PLL_RATE(1296000000, 54, 1, 0),
	PLL_RATE(1320000000, 55, 1, 0),
	PLL_RATE(1344000000, 56, 1, 0),
	PLL_RATE(1368000000, 57, 1, 0),
	PLL_RATE(1392000000, 58, 1, 0),
	PLL_RATE(1416000000, 59, 1, 0),
	PLL_RATE(1440000000, 60, 1, 0),
	PLL_RATE(1464000000, 61, 1, 0),
	PLL_RATE(1488000000, 62, 1, 0),
	PLL_RATE(1512000000, 63, 1, 0),
	PLL_RATE(1536000000, 64, 1, 0),
	{ /* sentinel */ },
	};

	static const struct clk_div_table cpu_div_table[] = {
	{ .val = 1, .div = 1 },
	{ .val = 2, .div = 2 },
	{ .val = 3, .div = 3 },
	{ .val = 2, .div = 4 },
	{ .val = 3, .div = 6 },
	{ .val = 4, .div = 8 },
	{ .val = 5, .div = 10 },
	{ .val = 6, .div = 12 },
	{ .val = 7, .div = 14 },
	{ .val = 8, .div = 16 },
	{ /* sentinel */ },
	};

	PNAME(p_fclk_div) = { "fixed_pll" };
	PNAME(p_cpu_clk) = { "sys_pll" };
	PNAME(p_clk81) = { "fclk_div3", "fclk_div4", "fclk_div5" };
	PNAME(p_mali) = { "fclk_div3", "fclk_div4", "fclk_div5",
	"fclk_div7", "zero" };

	static u32 mux_table_clk81[] = { 6, 5, 7 };
	static u32 mux_table_mali[] = { 6, 5, 7, 4, 0 };

	static const struct composite_conf clk81_conf __initconst = {
	.mux_table = mux_table_clk81,
	.mux_flags = CLK_MUX_READ_ONLY,
	.mux_parm = PARM(0x00, 12, 3),
	.div_parm = PARM(0x00, 0, 7),
	.gate_parm = PARM(0x00, 7, 1),
	};

	static const struct composite_conf mali_conf __initconst = {
	.mux_table = mux_table_mali,
	.mux_parm = PARM(0x00, 9, 3),
	.div_parm = PARM(0x00, 0, 7),
	.gate_parm = PARM(0x00, 8, 1),
	};

	static struct clk_fixed_rate meson8b_xtal = {
	.fixed_rate = 24000000,
	.hw.init = &(struct clk_init_data){
	.name = "xtal",
	.num_parents = 0,
	.ops = &clk_fixed_rate_ops,
	},
	};

	static struct clk_fixed_rate meson8b_zero = {
	.fixed_rate = 0,
	.hw.init = &(struct clk_init_data){
	.name = "zero",
	.num_parents = 0,
	.ops = &clk_fixed_rate_ops,
	},
	};

	static struct meson_clk_pll meson8b_fixed_pll = {
	.m = {
	.reg_off = MESON8B_REG_PLL_FIXED,
	.shift = 0,
	.width = 9,
	},
	.n = {
	.reg_off = MESON8B_REG_PLL_FIXED,
	.shift = 9,
	.width = 5,
	},
	.od = {
	.reg_off = MESON8B_REG_PLL_FIXED,
	.shift = 16,
	.width = 2,
	},
	.lock = &clk_lock,
	.hw.init = &(struct clk_init_data){
	.name = "fixed_pll",
	.ops = &meson_clk_pll_ro_ops,
	.parent_names = (const char *[]){ "xtal" },
	.num_parents = 1,
	.flags = CLK_GET_RATE_NOCACHE,
	},
	};

	static struct meson_clk_pll meson8b_vid_pll = {
	.m = {
	.reg_off = MESON8B_REG_PLL_VID,
	.shift = 0,
	.width = 9,
	},
	.n = {
	.reg_off = MESON8B_REG_PLL_VID,
	.shift = 9,
	.width = 5,
	},
	.od = {
	.reg_off = MESON8B_REG_PLL_VID,
	.shift = 16,
	.width = 2,
	},
	.lock = &clk_lock,
	.hw.init = &(struct clk_init_data){
	.name = "vid_pll",
	.ops = &meson_clk_pll_ro_ops,
	.parent_names = (const char *[]){ "xtal" },
	.num_parents = 1,
	.flags = CLK_GET_RATE_NOCACHE,
	},
	};

	static struct meson_clk_pll meson8b_sys_pll = {
	.m = {
	.reg_off = MESON8B_REG_PLL_SYS,
	.shift = 0,
	.width = 9,
	},
	.n = {
	.reg_off = MESON8B_REG_PLL_SYS,
	.shift = 9,
	.width = 5,
	},
	.od = {
	.reg_off = MESON8B_REG_PLL_SYS,
	.shift = 16,
	.width = 2,
	},
	.rate_table = sys_pll_rate_table,
	.rate_count = ARRAY_SIZE(sys_pll_rate_table),
	.lock = &clk_lock,
	.hw.init = &(struct clk_init_data){
	.name = "sys_pll",
	.ops = &meson_clk_pll_ops,
	.parent_names = (const char *[]){ "xtal" },
	.num_parents = 1,
	.flags = CLK_GET_RATE_NOCACHE,
	},
	};

	static const struct clk_conf meson8b_clk_confs[] __initconst = {
	FIXED_FACTOR_DIV(CLKID_FCLK_DIV2, "fclk_div2", p_fclk_div, 0, 2),
	FIXED_FACTOR_DIV(CLKID_FCLK_DIV3, "fclk_div3", p_fclk_div, 0, 3),
	FIXED_FACTOR_DIV(CLKID_FCLK_DIV4, "fclk_div4", p_fclk_div, 0, 4),
	FIXED_FACTOR_DIV(CLKID_FCLK_DIV5, "fclk_div5", p_fclk_div, 0, 5),
	FIXED_FACTOR_DIV(CLKID_FCLK_DIV7, "fclk_div7", p_fclk_div, 0, 7),
	CPU(MESON8B_REG_SYS_CPU_CNTL1, CLKID_CPUCLK, "a5_clk", p_cpu_clk,
	cpu_div_table),
	COMPOSITE(MESON8B_REG_HHI_MPEG, CLKID_CLK81, "clk81", p_clk81,
	CLK_SET_RATE_NO_REPARENT \| CLK_IGNORE_UNUSED, &clk81_conf),
	COMPOSITE(MESON8B_REG_MALI, CLKID_MALI, "mali", p_mali,
	CLK_IGNORE_UNUSED, &mali_conf),
	};

	/*
	* FIXME we cannot register two providers w/o breaking things. Luckily only
	* clk81 is actually used by any drivers. Convert clk81 to use
	* clk_hw_onecell_data last and flip the switch to call of_clk_add_hw_provider
	* instead of of_clk_add_provider in the clk81 conversion patch to keep from
	* breaking bisect. Then delete this comment ;-)
	*/
	static struct clk_hw_onecell_data meson8b_hw_onecell_data = {
	.hws = {
	[CLKID_XTAL] = &meson8b_xtal.hw,
	[CLKID_ZERO] = &meson8b_zero.hw,
	[CLKID_PLL_FIXED] = &meson8b_fixed_pll.hw,
	[CLKID_PLL_VID] = &meson8b_vid_pll.hw,
	[CLKID_PLL_SYS] = &meson8b_sys_pll.hw,
	},
	.num = CLK_NR_CLKS,
	};

	static struct meson_clk_pll *const meson8b_clk_plls[] = {
	&meson8b_fixed_pll,
	&meson8b_vid_pll,
	&meson8b_sys_pll,
	};

	static void __init meson8b_clkc_init(struct device_node *np)
	{
	void __iomem *clk_base;
	int ret, clkid, i;

	if (!meson_clk_init(np, CLK_NR_CLKS))
	return;

	/* Generic clocks and PLLs */
	clk_base = of_iomap(np, 1);
	if (!clk_base) {
	pr_err("%s: Unable to map clk base\n", __func__);
	return;
	}

	/* Populate base address for PLLs */
	for (i = 0; i < ARRAY_SIZE(meson8b_clk_plls); i++)
	meson8b_clk_plls[i]->base = clk_base;

	/*
	* register all clks
	* CLKID_UNUSED = 0, so skip it and start with CLKID_XTAL = 1
	*/
	for (clkid = CLKID_XTAL; clkid < CLK_NR_CLKS; clkid++) {
	/* array might be sparse */
	if (!meson8b_hw_onecell_data.hws[clkid])
	continue;

	/* FIXME convert to devm_clk_register */
	ret = clk_hw_register(NULL, meson8b_hw_onecell_data.hws[clkid]);
	if (ret)
	goto unregister;
	}

	meson_clk_register_clks(meson8b_clk_confs,
	ARRAY_SIZE(meson8b_clk_confs),
	clk_base);
	return;

	/* FIXME remove after converting to platform_driver/devm_clk_register */
	unregister:
	for (clkid = CLK_NR_CLKS - 1; clkid >= 0; clkid--)
	clk_hw_unregister(meson8b_hw_onecell_data.hws[clkid]);
	}
	CLK_OF_DECLARE(meson8b_clock, "amlogic,meson8b-clkc", meson8b_clkc_init);